2 Samuel 23:5 - Albert Barnes' Notes on the Bible

Although my house ... - The sense of this clause (according to the the King James Version) will be that David comparing the actual state of his family and kingdom during the later years of trouble and disaster with the prophetic description of the prosperity of the righteous king, and seeing how far it falls short, comforts himself by the terms of God’s covenant 2 Samuel 7:12-16 and looks forward to Messiah’s kingdom. The latter clause, “although he make it not to grow,” must then mean that, although at the present time the glory of his house was not made to grow, yet all his salvation and all his desire was made sure in the covenant which would be fulfilled in due time. But most modern commentators understand both clauses as follows: “Is not my house so with God that He has made with me an everlasting covenant,” etc.? “For all my salvation and all my desire, will He not cause it to spring up?” namely, in the kingdom of Solomon, and still more fully in the kingdom of Christ.