1 Samuel 1:3 - Matthew Poole's English Annotations on the Holy Bible

Yearly, to wit, at one of the solemn feasts, which probably was the passover, when he not only went up himself, but carried his wife and children with him. Compare 1 Samuel 1:7. Or, at the appointed days or times; Heb. from days to days; or, from time to time, i.e. at the three solemn feasts, when he, together with all other males, were obliged to go to worship God in the place appointed; and at other times, when he as a Levite was to go thither in his course. To sacrifice; not in his own person, which the Levites could not do, but by the priests; in which sense David, and Solomon, and Absalom are said to offer sacrifices, 2 Samuel 15:8 1 Kings 8:63 1 Chronicles 21:26. In Shiloh; where the tabernacle had long been, and now was. See Joshua 18:1 Judges 18:31, Judges 21:19. The priests of the Lord were there, or, were the priests of the Lord there, to wit, under their father Eli, who is generally conceived to have been the high priest, but being very old and infirm, 1 Samuel 4:15, and unfit for service, his sons ministered in his stead, being as it were second priests. See 2 Kings 25:18. And this clause seems to be added, to show that this good man did not run into that vulgar error, of neglecting his duty of offering to God for the wickedness of the priests; of which see 1 Samuel 2:17,24.