Genesis 38:1 - Joseph Benson’s Commentary on the Old and New Testaments

At that time That is, about that time; this expression, as also the words then, in those days, often referring in Scripture to a considerable space of time. For though these words, as Le Clerc well observes, seem to connect the following events with those spoken of in the former chapter, yet some of them, particularly Judah's marriage, which leads to the rest, must have happened long before Joseph was sold into Egypt. This chapter must therefore be here placed out of the order of time, and the events here recorded must have happened soon after Jacob came from Mesopotamia into Canaan, though Moses, for some special reasons, relates them in this place. Judah went down from his brethren Withdrew for a time from his father's family, and got intimately acquainted with one Hirah an Adullamite. When young people that have been well educated, begin to change their company, they will soon change their manners, and lose their good education. They that go down from their brethren, that forsake the society of the seed of Israel, and pick up Canaanites for their companions, are going down the hill apace.