Psalms 84:11 - Joseph Benson’s Commentary on the Old and New Testaments

The Lord God is a sun To enlighten, quicken, direct, and comfort all his people; whereas they that live without God in the world walk in darkness and know not whither they go, as is said John 12:35; and shield To defend them from all their enemies, and from those dreadful and destructive miseries which attend all other men. The Lord will give grace His favour and friendship, which are better than life. Psalms 63:3. And all the blessed fruits of it, especially the influences, gifts, and graces of his Spirit; and glory Not the vain glory and splendour of this world, of which David would not have spoken so magnificently, because, upon all occasions, he expresses a great contempt of these things; but the honour which comes from God here, and that eternal and ineffable glory laid up for God's people in the future world. No good thing will he withhold Nothing that is truly good in itself, and which would be good for them. This should be well observed, because sometimes afflictions, which are evil in themselves, are good, and necessary, and highly advantageous to good men; while the good things of this world, as they are called, would be very hurtful to them, as is verified by frequent experiments. From them that walk uprightly That worship and serve God sincerely, and order their conversation aright. Which clause David seems to add designedly, to prevent or remove an objection against what he had now advanced, which might be taken from his own case, whereby it appeared that God was no such sun or shield to him, but exposed him to great and sore calamities. Of which, as being certain and evident, David here assigns the true reason, which was, not any defect in God's goodness and all-sufficiency, but only his own gross misconduct, whereby he had clouded this sun, and cast away this shield, and forfeited these privileges by departing from his integrity.